-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring mvc #366
Spring mvc #366
Conversation
Pull request to synch with geonetwork/core-geonetwork repository
Update to master
…s (for groups list/edit)
… into spring-mvc
… into spring-mvc Conflicts: core/src/main/java/org/fao/geonet/kernel/setting/SettingManager.java core/src/main/resources/config-spring-geonetwork.xml domain/src/main/java/org/fao/geonet/domain/GeonetEntity.java domain/src/main/java/org/fao/geonet/domain/StatusValue.java pom.xml web/pom.xml web/src/main/webResources/WEB-INF/web.xml web/src/main/webapp/WEB-INF/classes/JZKitConfig.xml web/src/main/webapp/WEB-INF/config-security/config-security-mapping.xml web/src/main/webapp/WEB-INF/config-spring-geonetwork.xml
|
||
@Override | ||
public boolean getValueAsBool(String key) { | ||
throw new NotImplementedException(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these left as not implemented? I think they should either be removed from the API or implemented. It seems like a 1/2 finished job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't need it for the example service. The idea is to implement them "on the run" when we need them. Some of them may be a bit deprecated, I think, with the new way of saving settings on the database.
Very exciting. I was only this yesterday wondering what the status was on this work. I will give this a +1 once my comments are answered. |
… into spring-mvc
… into spring-mvc Conflicts: common/src/main/java/org/fao/geonet/utils/GeonetHttpRequestFactory.java
https://github.com/geonetwork/core-geonetwork/wiki/Spring-MVC