Feature/remove typestate pattern from model builder #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo-ant
added a commit
that referenced
this pull request
May 21, 2024
* add dev branch checks * Feature/remove typestate pattern from model builder (#30) * break everything, but now we have a state machine * more work on removing typestate * refactor should be finished * fix clippy lints * Feature/confidence bands (#32) * start with confidence bands * update comment * don't store correlation matrix anymore, instead calculate it on the fly * disable fit statistics for mrhs because that was not working correctly * start adding calculations * minor changes to calculations * finish draft for confidence bands * add generics for mrhs vs single rhs * compiling, but doctests are failing * offer different APIs for single and multiple rhs * single vector api in fit statistics * compile and tests working, doctests still fail * remove obsolete code * add best fit method and start testing it * add more tests for best fit * more tests for best fit * add docs for confidence bands * fix doctests * start changing docs to better reflect mrhs * start with python script using lmfit for comparison * fiddle with parameters until fit works, add random noise for ci calculation * minor cleanups in script * write results * start with tests for confidence band * add x data to output * more test assets * test and fix bugs in confidence band * move some test assets around * add weighted decay * test fitting with weights, found problem with covmat * smaller refactor * use correct cov matrix for weighted problem * shorten todo comment * use correct conf interval, fix test * doctest readme, fix problems * increment version * fmt * doc fixes * add reduced chi2 and add comment about scaling * test reduced chi2 * update readme * add todo list * update changelog, add todo list * more documentation * add test for the remove typestate feature * more doc * overhaul readme again and add todos * more corrections in readme, append todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the typestate pattern that made things more complicated. Related to the comments I made in this issue.