New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleaning of expired tokens #59

Open

m-ober wants to merge 1 commit into gbirke:master from m-ober:fix-clean-expired-tokens

Contributor

m-ober commented Nov 3, 2022

The column $expiresColumn stores the expiry timestamp, which is calculated like: $expire = time() + $this->expireTime.

OTOH, the code to clean the expired tokens looks like this:

if ($this->cleanExpiredTokensOnLogin) {
    $this->storage->cleanExpiredTokens(time() - $this->expireTime);
}

This leads to the tokens being valid for twice the expireTime.


          Fix cleaning of expired tokens

2dbdcfd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet