Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

RFC: Remove special layouts from v2 #2

Merged
merged 7 commits into from
May 4, 2018
Merged

RFC: Remove special layouts from v2 #2

merged 7 commits into from
May 4, 2018

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Apr 6, 2018 •
edited
Loading

@KyleAMathews
Copy link
Contributor Author

This RFC has entered the final comment period.

@KyleAMathews
Copy link
Contributor Author

I merged a PR implementing this into v2, in the process upgrading a number of sites — check it out! gatsbyjs/gatsby#4887

@sqrtroot
Copy link

Maybe the Context Api is something that could be considered for passing down these static queries all troughout the application? This would allow getting this page data without passing props around trough the whole app.

@KyleAMathews
Copy link
Contributor Author

Yeah! I ended up using context for loading the data in development — in production, the babel plugin adds an import directly the query result so webpack handles bundling the component query result.

@jlengstorf jlengstorf mentioned this pull request May 1, 2018
Closed
@KyleAMathews
Copy link
Contributor Author

The PR has now been implemented and quite a few sites upgraded and everything seems 👌so merging!

@KyleAMathews KyleAMathews merged commit 59fa73c into master May 4, 2018
@KyleAMathews KyleAMathews deleted the remove-layouts branch May 4, 2018 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleAMathews @sqrtroot