Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy using-gatsby-source-graphql example #9968

Merged
merged 1 commit into from
Nov 16, 2018
Merged

tidy using-gatsby-source-graphql example #9968

merged 1 commit into from
Nov 16, 2018

Conversation

rdela
Copy link
Contributor

@rdela rdela commented Nov 16, 2018

Minor cleanup:

  • repair links in readme and index pointing to plugins/ instead of packages/
  • add fitting name and description in package.json in style of using-gatsby-image:
    "name": "using-gatsby-image",
    "private": true,
    "description": "Gatsby example site using using-gatsby-image",
  • babel-eslint to ^8.2.2 to remedy various compile errors in yarn and this more informative npm error:
    npm WARN eslint-config-react-app@3.0.0-next.66cc7a90 requires a peer of babel-eslint@^8.2.2 but none is installed. You must install peer dependencies yourself.
    ...seems like we might could go higher: https://github.com/babel/babel-eslint/releases
    ...but this fixes the issues and allows me to build the example in yarn 1.12.3 and npm 6.4.1 on node 10.13.0.

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rdela!

@pieh pieh merged commit ad36d85 into gatsbyjs:master Nov 16, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 16, 2018

Holy buckets, @rdela — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@rdela rdela deleted the links-source-graphql branch January 5, 2019 01:24
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Minor cleanup:

- repair links in readme and index pointing to plugins/ instead of packages/
- add fitting name and description in package.json in style of using-gatsby-image: https://github.com/gatsbyjs/gatsby/blob/44db2f70967fd4408a86590899038c9f16eb4e5d/examples/using-gatsby-image/package.json#L2-L4
- babel-eslint to ^8.2.2 to remedy various compile errors in yarn and this more informative npm error:
  ```bash
  npm WARN eslint-config-react-app@3.0.0-next.66cc7a90 requires a peer of babel-eslint@^8.2.2 but none is installed. You must install peer dependencies yourself.
  ```
  ...seems like we might could go higher: https://github.com/babel/babel-eslint/releases
  ...but this fixes the issues and allows me to build the example in yarn 1.12.3 and npm 6.4.1 on node 10.13.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants