Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blog): A tutorial on how to create a lightbox using gatsby-image and @reach/dialog #9684

Merged
merged 8 commits into from
Dec 20, 2018
Merged

feat(blog): A tutorial on how to create a lightbox using gatsby-image and @reach/dialog #9684

merged 8 commits into from
Dec 20, 2018

Conversation

sergical
Copy link
Contributor

@sergical sergical commented Nov 3, 2018 •
edited by jlengstorf
Loading

closes #7005

@sergical sergical requested a review from a team November 3, 2018 18:38
@sergical sergical mentioned this pull request Nov 3, 2018
Closed
jlengstorf
jlengstorf previously requested changes Nov 3, 2018
View reviewed changes
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Made a couple small suggestions.

docs/blog/2018-11-03-building-an-accessible-lightbox/index.md Outdated Show resolved Hide resolved
docs/blog/2018-11-03-building-an-accessible-lightbox/index.md Outdated Show resolved Hide resolved
docs/blog/2018-11-03-building-an-accessible-lightbox/index.md Outdated Show resolved Hide resolved
jlengstorf and others added 2 commits November 3, 2018 18:16
@jlengstorf @sergical
Update docs/blog/2018-11-03-building-an-accessible-lightbox/index.md
f246812 
Co-Authored-By: 416serg <hey@416serg.me>
@sergical
Update index.md
7730b86 
Updates as per suggestions
@sergical
Copy link
Contributor Author

sergical commented Nov 3, 2018

@jlengstorf thanks for the feedback and good call on the changes! 👍🏼 it's ready whenever you are 😃

shannonbux
shannonbux previously requested changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@shannonbux shannonbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @416serg! This is looking great! What an exciting tutorial :)

Two overall pieces of feedback:

  • The tutorial flows really well from step to step. Love that!
  • A suggestion on pronouns. The Gatsby Style Guide advises using "you" / "your" / "you need to" as the main pronouns in tutorials instead of "we" / "our" / "let's". This change makes sure the reader knows what they are supposed to do. https://www.gatsbyjs.org/docs/gatsby-style-guide/#use-you-as-the-pronoun

docs/blog/2018-11-03-building-an-accessible-lightbox/index.md Outdated Show resolved Hide resolved
sergical added a commit that referenced this pull request Nov 6, 2018
@sergical
Update how-to-contribute.md
51e6e95 
While creating a tutorial #9684, @shannonbux uncovered a handy piece of content here ❤️
@sergical sergical mentioned this pull request Nov 6, 2018
Merged
DSchau pushed a commit that referenced this pull request Nov 6, 2018
@sergical @DSchau
Update how-to-contribute.md to mention the style guide when writing b…
1a1bd3a 
…logs/tutorials (#9742)

While creating a tutorial #9684, @shannonbux uncovered a handy piece of content here ❤️

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
@shannonbux
Copy link
Contributor

Looks great @416serg! Let me just ask our director of marketing about what date to publish this! Awesome work! It isn't easy to change from "we" to "you"--I've done it many times myself :)

@m-allanson m-allanson changed the title A tutorial on how to create a lightbox using gatsby-image and @reach/dialog feat(blog): A tutorial on how to create a lightbox using gatsby-image and @reach/dialog Dec 17, 2018
@m-allanson m-allanson dismissed stale reviews from shannonbux and jlengstorf December 17, 2018 10:53

PR has been updated with review feedback 👍

@m-allanson m-allanson self-assigned this Dec 17, 2018
@m-allanson m-allanson added the status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. label Dec 17, 2018
m-allanson
m-allanson approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @416serg, thank you!

I've queued this up to be published on Thursday 🎉

@m-allanson m-allanson merged commit 0e95720 into gatsbyjs:master Dec 20, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@sergical @gpetrioli
Update how-to-contribute.md to mention the style guide when writing b…
16066a1 
…logs/tutorials (gatsbyjs#9742)

While creating a tutorial gatsbyjs#9684, @shannonbux uncovered a handy piece of content here ❤️

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@sergical @gpetrioli
feat(blog): A tutorial on how to create a lightbox using gatsby-image…
a655088 
… and @reach/dialog (gatsbyjs#9684)

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

closes gatsbyjs#7005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-allanson m-allanson m-allanson approved these changes

@pranshuchittora pranshuchittora pranshuchittora approved these changes

@jlengstorf jlengstorf jlengstorf left review comments

@shannonbux shannonbux shannonbux left review comments

Assignees

@m-allanson m-allanson

Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Add a "how to create a lightbox" guide/tutorial
5 participants
@sergical @shannonbux @jlengstorf @m-allanson @pranshuchittora