Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-plugin-netlify generates wrong js Link #6536

Closed
wants to merge 1 commit into from
Closed

gatsby-plugin-netlify generates wrong js Link #6536

wants to merge 1 commit into from

Conversation

porfirioribeiro
Copy link
Contributor

The _headers file generated is like:

/404.html
  Link: </webpack-runtime-538a792ce8cbb482dfed.js>; rel=preload; as=script
  Link: </component---src-pages-404-js-c6e3c0efeaf493f3355e.js>; rel=preload; as=script

When public folder was rearranged and js files start be puted on /public/js broke this

The _headers file generated is like:
```
/404.html
  Link: </webpack-runtime-538a792ce8cbb482dfed.js>; rel=preload; as=script
  Link: </component---src-pages-404-js-c6e3c0efeaf493f3355e.js>; rel=preload; as=script
```
When `public` folder was rearranged and js files start be puted on `/public/js` broke this
@KyleAMathews
Copy link
Contributor

Deploy preview for using-postcss-sass failed.

Built with commit 66de053

https://app.netlify.com/sites/using-postcss-sass/deploys/5b4f6770c6aed63a5eb90f45

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 66de053

https://deploy-preview-6536--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 66de053

https://deploy-preview-6536--using-drupal.netlify.com

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @porfirioribeiro 👍

@m-allanson
Copy link
Contributor

#6346 was reverted, so I don't think this change is necessary any more. Closing. Thanks for picking this up @porfirioribeiro.

@m-allanson m-allanson closed this Jul 20, 2018
@porfirioribeiro porfirioribeiro deleted the patch-1 branch July 20, 2018 12:45
@porfirioribeiro
Copy link
Contributor Author

Ok, glad that it's fixed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants