Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-plugin-google-analytics] Extends OutboundLink onClick event instead of override it #4999

Merged
merged 1 commit into from
Apr 16, 2018
Merged

[gatsby-plugin-google-analytics] Extends OutboundLink onClick event instead of override it #4999

merged 1 commit into from
Apr 16, 2018

Conversation

valse
Copy link
Contributor

@valse valse commented Apr 16, 2018

As subject extends the onClick event defined in the OutboundLink component, for example for logging purpose.

<OutboundLink
  href="https://www.gatsbyjs.org/packages/gatsby-plugin-google-analytics/"
  onClick={this.log}
>
  Visit the Google Analytics plugin page!
</OutboundLink>

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 81a5912

https://deploy-preview-4999--gatsbygram.netlify.com

@dangerbot-gatsby
Copy link

Messages
📖

Gatsby requires contributors to sign each commit.

You can do this for your branch with git rebase --signoff, or for a single commit with git commit --amend -s.

Check out the Developer Certificate of Origin docs or comment here if you've any questions.

Generated by 🚫 dangerJS

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 81a5912

https://deploy-preview-4999--using-drupal.netlify.com

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valse

@KyleAMathews KyleAMathews merged commit e83dc39 into gatsbyjs:master Apr 16, 2018
@KyleAMathews
Copy link
Contributor

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants