[v2] Refactor loading Babel to make it behave like rest of Gatsby #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jquense
reviewed
Mar 2, 2018
| useBuiltIns: `usage`, | ||
| sourceType: `unambiguous`, | ||
| shippedProposals: true, // includes async/await and Object spread/rest | ||
| targets: { browsers: browserslist }, |
There was a problem hiding this comment.
I learned the hard way the other day that preset-env should always force include object-rest-spread (https://github.com/4Catalyzer/babel-preset-4catalyzer/blob/master/index.js#L41) webpack can't handle the syntax even if the browser can.
There was a problem hiding this comment.
Huh, that sounds really painful to debug.
shippedProposals does add this — perhaps we should validate user's babelrcs to make sure they've either set shippedPropsals or that they include it directly.
KyleAMathews
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e use Redux + new API
onCreateBabelccThis should make understanding & using the API more fool-proof + this
PR is adding a bunch of tests where loading babelrc previously had no tests.
TODOs