Upgrade babel@7 #3785

jquense · 2018-01-31T00:25:40Z

First pass at a v7 upgrade for babel. Mostly just dep updates, but it also has some opinions about the default babel config used for a site.

I'd defer a change in the babel plugin api till after this is merged

jquense · 2018-01-31T00:26:49Z

packages/gatsby-link/__tests__/index.js

@@ -0,0 +1,167 @@
+"use strict";


jquense · 2018-01-31T00:27:40Z

packages/gatsby-plugin-aphrodite/.gitignore

@@ -1,2 +0,0 @@
-/*.js
-!index.js


removing stub pacakges because babel now complains if you try and run it without files so these all break the build

Out of curiosity, what error were you seeing here? This could just be an accidental regression on Babel's side.

babel now exits with a non-zero if the cli call doesn't end up with any files that it can transpile. It's probably not a bad change, but it messes with our scaffolding a bit, which assumes you'll use babel, but these stub packages don't actually have any files in src/

Gotcha. I don't know if that was an intentional change or not on our end. I feel like as long as the directory itself exists, the fact that there are no files shouldn't be an error.

Filed: babel/babel#7337

jquense · 2018-01-31T00:29:18Z

packages/gatsby/src/utils/babel-config.js

-  }
-  if (!babelrc.presets) {
-    babelrc.presets = []
+    babelrc = {


instead of what we were doing if there is no babelrc provide a full default config to use that covers most cases. otherwise let the user pick. no magically borrowing of what gatsby has installed in keeping with the other resolution changes we've been making

It looks like this may be bugged. babelrc is initialized as

let babelrc = ... || {};

so it should never be falsy?

jquense · 2018-01-31T00:29:35Z

packages/gatsby/src/utils/babel-config.js

-    babelrc.presets = []
+    babelrc = {
+      cacheDirectory: true,
+      plugins: [],


should probably include class properties

Looking at CRA's babel 7 upgrade PR – just copy their plugin list I think? https://github.com/facebook/create-react-app/pull/3522/files#diff-4dea0a44b1f2f65c2294fd4dae2e25f7R72

jquense · 2018-01-31T15:27:49Z

it should be said that there is no chance netlify will pass because so many deps changed

KyleAMathews · 2018-01-31T16:47:24Z

Your prediction came true :-)

This is awesome! I'll be going through PRs later & also merging master into v2 so will check this out then.

loganfsmyth

A bit of feedback and questions from my quick glance through.

loganfsmyth · 2018-02-06T00:29:57Z

.babel-preset.js

        Object.assign(
          {
            loose: true,
            debug: !!debug,
-            useBuiltIns: true,
+            useBuiltIns: "entry",
+            shippedProposals: true,
            modules: "commonjs",


This should set sourceType: "unambiguous" probably.

loganfsmyth · 2018-02-06T00:31:01Z

.babel-preset.js

@@ -25,31 +24,31 @@ function preset(context, options = {}) {
  return {


The filename seems less than ideal. Should we ditch the . prefix on this?

probably, originally this was this was that fake babelrc.js pattern, but we don't actually want it to be a rc file since other packages use it as a preset. I think i left the . simply to keep the files close together, we should probably move this it a real package tho

Your call really. I get the point as far as keeping them together, I do tend to think dotfiles get confusing though.

loganfsmyth · 2018-02-06T00:41:56Z

packages/gatsby-plugin-canonical-urls/package.json

@@ -14,11 +14,12 @@
  "author": "Kyle Mathews <mathews.kyle@gmail.com>",
  "license": "MIT",
  "devDependencies": {
-    "babel-cli": "^6.26.0",
+    "@babel/cli": "^7.0.0-beta.38",
+    "@babel/core": "^7.0.0-beta.38",


I know this was already how it was, but is there any reason to have these each independently depend on @babel/core, when building in the first place depends on the .babel-preset.js from the root? Why not install this in the root instead?

the preset is in the root but the build call is local to each package. Its a balance between keeping packages reasonablly independant so different folks can maintain them while also making repo wide stuff a bit easier. so since each package depends on babel/cli core is need b/c peer deps

Gotcha, guess that makes sense then.

loganfsmyth · 2018-02-06T00:50:33Z

packages/gatsby-transformer-javascript-static-exports/src/gatsby-node.js

@@ -15,18 +15,30 @@ async function onCreateNode({ node, getNode, actions, loadNodeContent }) {
  const options = {
    sourceType: `module`,


Probably want sourceType: "unambiguous"

I'll admit i'm fairly unfamiliar with what this option does

Until the community starts properly transitioning to using .mjs files, Babel needs to either told what type of files it is going to get, or it needs to be told to guess. Parsing as a module ends up meaning it is auto-strict, among other things. Setting unambiguous basically means it will attempt to autodetect the type, but might get in wrong in some cases. It should avoid the need for strictMode: false though since it'll only be auto-strict if the user used import or export statements.

loganfsmyth · 2018-02-06T00:51:04Z

packages/gatsby-transformer-javascript-static-exports/src/gatsby-node.js

@@ -15,18 +15,30 @@ async function onCreateNode({ node, getNode, actions, loadNodeContent }) {
  const options = {
    sourceType: `module`,
    allowImportExportEverywhere: true,
+    strictMode: false,


This may be addressed by sourceType: "module" here? What was this trying to address?

i think i copied this whole cloth from the relay-compiler setup, o rather i did in the babel plugin and then copied those options here.

Fair enough. See my comment above about unambiguous.

loganfsmyth · 2018-02-06T00:56:23Z

packages/gatsby/package.json

-    "babel-core": "^6.24.1",
+    "@babel/code-frame": "^7.0.0-beta.38",
+    "@babel/core": "^7.0.0-beta.38",
+    "babel-core": "^7.0.0-0",
    "babel-loader": "^7.1.2",


There's a beta version of this that depends on @babel/core directly FYI.

loganfsmyth · 2018-02-06T00:58:34Z

packages/gatsby/src/internal-plugins/query-runner/file-parser.js

+  allowImportExportEverywhere: true,
+  allowReturnOutsideFunction: true,
+  allowSuperOutsideMethod: true,
+  sourceType: `module`,


I'd recommend unambiguous here too.

loganfsmyth · 2018-02-06T01:04:37Z

packages/gatsby/src/utils/babel-config.js

-  }
-  if (!babelrc.presets) {
-    babelrc.presets = []
+    babelrc = {


It looks like this may be bugged. babelrc is initialized as

let babelrc = ... || {};

so it should never be falsy?

loganfsmyth · 2018-02-06T01:19:41Z

packages/gatsby-1-config-css-modules/__tests__/index.js

@@ -0,0 +1,38 @@
+var _require = require(`../index`),


Looks like this was accidentally committed?

yeah, a failure to handle the right babel ignores i think

loganfsmyth · 2018-02-06T01:21:04Z

packages/gatsby-plugin-aphrodite/.gitignore

@@ -1,2 +0,0 @@
-/*.js
-!index.js


Out of curiosity, what error were you seeing here? This could just be an accidental regression on Babel's side.

KyleAMathews · 2018-02-10T00:09:32Z

Thanks! Really appreciate your work as always!

* Upgrade babel@7 * Set sourceType to 'unambigious' * Remove strictMode and use sourceType: unambigious * Upgrade to babel-loader@8.0.0-beta.0 * remove accidentally commited files + improve .gitignore * Change order to remove comment ;-) * Add more stuff * rm compiled tests folders * fix some broken tests due to merge * fix test ignores

Upgrade babel@7

d3bdb89

ghost assigned jquense Jan 31, 2018

ghost added the review label Jan 31, 2018

jquense commented Jan 31, 2018

View reviewed changes

packages/gatsby-link/__tests__/index.js Outdated

@@ -0,0 +1,167 @@

"use strict";

Copy link

Contributor Author

jquense Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARG!

jquense commented Jan 31, 2018

View reviewed changes

loganfsmyth reviewed Feb 6, 2018

View reviewed changes

loganfsmyth mentioned this pull request Feb 6, 2018

Babel CLI returning non-zero if directory is empty? babel/babel#7337

Closed

Set sourceType to 'unambigious'

c581534

ghost assigned KyleAMathews Feb 9, 2018

KyleAMathews and others added 9 commits February 8, 2018 17:12

Remove strictMode and use sourceType: unambigious

2c69446

Upgrade to babel-loader@8.0.0-beta.0

5c69cbb

remove accidentally commited files + improve .gitignore

f3fcb6e

Change order to remove comment ;-)

bec1c9d

Add more stuff

829944d

rm compiled tests folders

d97a736

fix some broken tests due to merge

7137af5

fix test ignores

fea4087

Merge branch 'v2' into babel-upgrade

84754cc

KyleAMathews merged commit 4bfe9a9 into v2 Feb 10, 2018

ghost removed the review label Feb 10, 2018

KyleAMathews deleted the babel-upgrade branch February 10, 2018 00:09

KyleAMathews mentioned this pull request Feb 10, 2018

[v2] Update Babel to v7 #3492

Closed

TuckerWhitehouse mentioned this pull request Feb 16, 2018

v2 Umbrella issue #2641

Closed

13 tasks

ajesse11x mentioned this pull request Aug 11, 2022

[Snyk] Upgrade axios from 0.18.1 to 0.27.2 ajesse11x/gatsby#1405

Open

snyk-bot mentioned this pull request Jan 3, 2023

[Snyk] Upgrade axios from 0.19.2 to 0.27.2 nidhi42/gatsby#1761

Open

tonyg101 mentioned this pull request Jul 29, 2023

[Snyk] Upgrade axios from 0.19.2 to 0.27.2 signal-noise/gatsby#3

Open

This was referenced Sep 23, 2023

[Snyk] Upgrade axios from 0.20.0 to 0.27.2 X-oss-byte/gatsby-1#53

Open

[Snyk] Upgrade axios from 0.20.0 to 0.27.2 X-oss-byte/gatsby-1#62

Open

[Snyk] Upgrade axios from 0.20.0 to 0.27.2 X-oss-byte/gatsby-1#73

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade babel@7 #3785

Upgrade babel@7 #3785

jquense commented Jan 31, 2018

jquense Jan 31, 2018

jquense Jan 31, 2018

loganfsmyth Feb 6, 2018

jquense Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

jquense Jan 31, 2018

loganfsmyth Feb 6, 2018

jquense Jan 31, 2018

KyleAMathews Feb 9, 2018

jquense commented Jan 31, 2018

KyleAMathews commented Jan 31, 2018

loganfsmyth left a comment

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

jquense Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

jquense Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

jquense Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

jquense Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

loganfsmyth Feb 6, 2018

jquense Feb 6, 2018

loganfsmyth Feb 6, 2018

KyleAMathews commented Feb 10, 2018

		@@ -25,31 +24,31 @@ function preset(context, options = {}) {
		return {

		@@ -15,18 +15,30 @@ async function onCreateNode({ node, getNode, actions, loadNodeContent }) {
		const options = {
		sourceType: `module`,

		@@ -1,2 +0,0 @@
		/*.js
		!index.js

		@@ -1,2 +0,0 @@
		/*.js
		!index.js

Upgrade babel@7 #3785

Upgrade babel@7 #3785

Conversation

jquense commented Jan 31, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jquense commented Jan 31, 2018

KyleAMathews commented Jan 31, 2018

loganfsmyth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KyleAMathews commented Feb 10, 2018