Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-wordpress): Add back nodeType field that was removed in last version #37212

Merged
merged 6 commits into from
Dec 8, 2022

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Dec 7, 2022

In #37134 I removed the nodeType field instead of adding it to more types (in order to get the schema to build properly). This was a breaking change but since I believed people didn't use this field I thought that was ok (adding the field was a mistake originally). Turns out lots of people use this field so I'm adding it back + adding it to more types than before to get the schema to build properly.

Related to #37114

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 7, 2022
@TylerBarnes TylerBarnes added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 7, 2022
@TylerBarnes TylerBarnes added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 7, 2022
@TylerBarnes TylerBarnes merged commit b7d7b07 into master Dec 8, 2022
@TylerBarnes TylerBarnes deleted the fix/wp-graphql-1.13-follow-up branch December 8, 2022 00:05
pieh pushed a commit that referenced this pull request Dec 8, 2022
…d in last version (#37212)

* canary commit

* move typedef interfaces definition to __all type filter

* add the nodeType field to any type that implements Node

* Revert "canary commit"

This reverts commit fd7f83d.

* update snapshot

(cherry picked from commit b7d7b07)
pieh pushed a commit that referenced this pull request Dec 8, 2022
…d in last version (#37212)

* canary commit

* move typedef interfaces definition to __all type filter

* add the nodeType field to any type that implements Node

* Revert "canary commit"

This reverts commit fd7f83d.

* update snapshot

(cherry picked from commit b7d7b07)
pieh pushed a commit that referenced this pull request Dec 8, 2022
…d in last version (#37212) (#37219)

* canary commit

* move typedef interfaces definition to __all type filter

* add the nodeType field to any type that implements Node

* Revert "canary commit"

This reverts commit fd7f83d.

* update snapshot

(cherry picked from commit b7d7b07)

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
pieh pushed a commit that referenced this pull request Dec 8, 2022
…d in last version (#37212) (#37218)

* canary commit

* move typedef interfaces definition to __all type filter

* add the nodeType field to any type that implements Node

* Revert "canary commit"

This reverts commit fd7f83d.

* update snapshot

(cherry picked from commit b7d7b07)

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants