Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-wordpress): MediaItem.excludeFieldNames / auto exclude interface types that have no fields (#37062) #37085

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

LekoArts
Copy link
Contributor

Backporting #37062 to the 4.24 release branch

(cherry picked from commit 0501ed3)

…lude interface types that have no fields (#37062)

* allow MediaItem type to use excludeFieldNames option

* make sure cached media item nodes always return the MediaItem node, not File nodes if those are cached

* use get type settings helper instead of accessing settings on options

* auto exclude interface types that have no fields due to an implementing type excluding all of it's fields

* this should've been excluded before! Fixed now

* update comment

* use Map for caching instead of object properties

* exclude MediaItem.template field in tests

* remove debug code

(cherry picked from commit 0501ed3)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 23, 2022
@LekoArts LekoArts changed the title feat(gatsby-source-wordpress): MediaItem.excludeFieldNames / auto exc… feat(gatsby-source-wordpress): MediaItem.excludeFieldNames / auto exclude interface types that have no fields (#37062) Nov 23, 2022
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 23, 2022
@LekoArts LekoArts merged commit 2bc5902 into release/4.24 Nov 23, 2022
@LekoArts LekoArts deleted the backport-4.24-37062 branch November 23, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants