Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Improvements to GraphQL TypeScript Generation #35581

Merged
merged 10 commits into from
May 5, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented May 3, 2022

Description

Follow-up to #35487 - The goal here is to get this feature into a GA-Ready state.

TODOs:

  • Proper E2E tests that also test the hot-reloading behavior and correct contents
  • Skip creating graphql.config.json if it already exists
  • Listen to SET_SCHEMA and SET_GRAPHQL_DEFINITIONS and only then run the activites
  • Add pluckConfig to only look at graphql() function from Gatsby

Documentation

Will be added here: #35584

Related Issues

RFC: #35420

[ch49658]
[ch49877]
[ch50092]

@LekoArts LekoArts added the topic: GraphQL Related to Gatsby's GraphQL layer label May 3, 2022
@LekoArts LekoArts added this to the GraphQL TypeScript Generation milestone May 3, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 3, 2022
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 3, 2022
@LekoArts LekoArts marked this pull request as ready for review May 4, 2022 14:20
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LekoArts LekoArts merged commit 966aca8 into master May 5, 2022
@LekoArts LekoArts deleted the typegen-one branch May 5, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants