Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-dev-cli): use package name not directory name #35447

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix(gatsby-dev-cli): use package name not directory name #35447

merged 1 commit into from
Apr 21, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Apr 19, 2022

Testing potential solution for gatsby-dev-cli issue encountered in #35446 where new package is not being handled

@pieh pieh added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Apr 19, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 19, 2022
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 19, 2022
@pieh pieh changed the base branch from parcel-move-plugin to master April 20, 2022 11:18
@pieh pieh added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged labels Apr 20, 2022
@pieh pieh marked this pull request as ready for review April 20, 2022 17:10
LekoArts
LekoArts approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🎉

@LekoArts LekoArts merged commit 028f348 into master Apr 21, 2022
@LekoArts LekoArts deleted the parcel-move-plugin-gdc branch April 21, 2022 08:37
@LekoArts LekoArts mentioned this pull request Jun 24, 2022
Merged
This was referenced Nov 27, 2023
Open
Open
This was referenced Apr 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieh @LekoArts