perf: move id.eq fast path handling to node-model so it's shared between query running strategies #34520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ween query running strategies
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: GraphQL
pieh
changed the title
wardpeet
approved these changes
Jan 17, 2022
| Object.keys(query.filter.id).length === 1 | ||
| ) { | ||
| if (tracer) { | ||
| runQueryActivity = reporter.phantomActivity(`runQuerySimpleIdEq`, { |
There was a problem hiding this comment.
What's the goal of this phantomActivity? To see it in tracing?
There was a problem hiding this comment.
Yes, just for instrumentation. This code path skips runQuery activity, so I replaced it with something so traces make more sense
|
Woot! |
wardpeet
pushed a commit
to wardpeet/gatsby
that referenced
this pull request
Jan 19, 2022
…ween query running strategies (gatsbyjs#34520)
marvinjude
changed the title
This was referenced Jan 25, 2022
This was referenced Jan 26, 2022
This was referenced Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems we lost our fast path for simple
id.eqqueries and only had a path like that for LMDB (experimental) indexes. I moved this to much earlier in the pipeline (node-model).This should mean fast filters WON'T create a lookup table for it. The idea here is to limit the usage of it where possible, as (right now) those lookup tables cause nodes to be retained in memory and also not needed as we can already grab nodes by id.
Related Issues
[sc-44551]