Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-drupal): handle edge case with deleting nodes #33143

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

KyleAMathews
Copy link
Contributor

In this case, when trying to deleting a node's references nodes, we were
crashing if the referenced node had already been deleted.

In this case, when trying to deleting a node's references nodes, we were crashing if the referenced
node had already been deleted.
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 10, 2021
Copy link
Contributor

@benrobertsonio benrobertsonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@KyleAMathews KyleAMathews added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: bug An issue or pull request relating to a bug in Gatsby topic: source-drupal Related to Gatsby's integration with Drupal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 10, 2021
@KyleAMathews KyleAMathews merged commit 2f2880e into master Sep 10, 2021
@KyleAMathews KyleAMathews deleted the drupal-delete-fixes branch September 10, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-drupal Related to Gatsby's integration with Drupal type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants