Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade got package #32928

Merged
merged 9 commits into from
Sep 1, 2021
Merged

chore: upgrade got package #32928

merged 9 commits into from
Sep 1, 2021

Conversation

wardpeet
Copy link
Contributor

Description

Move all got deps to latest version

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 26, 2021
@wardpeet wardpeet added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 26, 2021
@wardpeet wardpeet force-pushed the chore/upgrade-got branch 2 times, most recently from 86761a4 to ef20b74 Compare August 27, 2021 09:51
@ascorbic
Copy link
Contributor

It looks like I forgot to add got as a dependency to gatsby-core-utils when I moved the file downloading code over.

@wardpeet
Copy link
Contributor Author

It's easily forgotten. That why we should add something like dependency-cruiser to fail when missing packages are used.

@ascorbic
Copy link
Contributor

That's neat. Not seen that before. Looks like it's very useful for monorepos.

@axe312ger
Copy link
Collaborator

@wardpeet I use https://www.npmjs.com/package/check-dependencies to avoid this in my themes. It does not support the gatsby-config.js though.

@ascorbic
Copy link
Contributor

Could got be added to gatsby-core-utils in this PR?

@axe312ger
Copy link
Collaborator

Could got be added to gatsby-core-utils in this PR?

+1 on this

@wardpeet
Copy link
Contributor Author

I thought I added it, now I did :) thanks!

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wardpeet wardpeet merged commit 2ac366e into master Sep 1, 2021
@wardpeet wardpeet deleted the chore/upgrade-got branch September 1, 2021 06:22
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Co-authored-by: Lennart <lekoarts@gmail.com>
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Co-authored-by: Lennart <lekoarts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants