fix(gatsby-source-contentful): improve error message when dominant color can't be generated #31879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my application, I was getting the following error logged hundreds of times: ``` [gatsby-source-contentful] Please install gatsby-plugin-sharp ``` I had gatsby-plugin-sharp installed as a plugin though. I added logging of the error to the log line and it turns out the error had to do with `cacheImage` not being able to load an image and not the fact that gatsby-plugin-sharp was not installed. This commit moves the `require` of gatsby-plugin-sharp to it's own `try` block and updates the error messaging of this block to have the error when an exception is thrown.
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: source-contentful
wardpeet
changed the title
This was referenced Jun 23, 2021
This was referenced Jan 18, 2022
This was referenced Oct 28, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In my application, I was getting the following error logged hundreds of
times:
I had gatsby-plugin-sharp installed as a plugin though. I added logging
of the error to the log line and it turns out the error had to do with
cacheImagenot being able to load an image and not the fact thatgatsby-plugin-sharp was not installed.
This commit moves the
requireof gatsby-plugin-sharp to it's owntryblock and updates the error messaging of this block to have the error
when an exception is thrown.
Documentation
Related Issues