Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): Handle fractional image sizes #31057

Merged
merged 1 commit into from
Apr 26, 2021
Merged

fix(gatsby-plugin-sharp): Handle fractional image sizes #31057

merged 1 commit into from
Apr 26, 2021

Conversation

ascorbic
Copy link
Contributor

This PR includes two fixes to the handling of fractional image sizes.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 26, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 26, 2021
wardpeet
wardpeet approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 26, 2021
@ascorbic ascorbic merged commit 08dfb37 into master Apr 26, 2021
@ascorbic ascorbic deleted the fix/fractional-dimensions branch April 26, 2021 13:16
@gatsbybot gatsbybot mentioned this pull request Apr 27, 2021
Merged
vladar pushed a commit that referenced this pull request Apr 27, 2021
@ascorbic @vladar
fix(gatsby-plugin-sharp): Handle fractional image sizes (#31057)
6626ac4 
(cherry picked from commit 08dfb37)
vladar pushed a commit that referenced this pull request Apr 27, 2021
@ascorbic
fix(gatsby-plugin-sharp): Handle fractional image sizes (#31057) (#31081
21dc379 
)

(cherry picked from commit 08dfb37)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(gatsby-plugin-sharp): Handle fractional image sizes (gatsbyjs#31057)
c88d21a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-sharp] calculating non-Integer sizes for images
2 participants
@ascorbic @wardpeet