Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-gatsby): Use legacy peer deps #29856

Merged
merged 2 commits into from
Mar 1, 2021
Merged

fix(create-gatsby): Use legacy peer deps #29856

merged 2 commits into from
Mar 1, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 1, 2021

Two npm 7 fixes. Passes --legacy-peer-deps to npm when setting-up, to align behaviour across versions. Also formats package.json, as installing no longer does

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@ascorbic ascorbic added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 1, 2021
LekoArts
LekoArts previously approved these changes Mar 1, 2021
View reviewed changes
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 1, 2021
@ascorbic ascorbic merged commit a92b276 into master Mar 1, 2021
@ascorbic ascorbic deleted the fix/init-legacy-peer-deps branch March 1, 2021 11:56
vladar pushed a commit that referenced this pull request Mar 1, 2021
@ascorbic @vladar
fix(create-gatsby): Use legacy peer deps (#29856)
92d7577 
* fix(create-gatsby): Use legacy peer deps

* Update tests

(cherry picked from commit a92b276)
@gatsbybot gatsbybot mentioned this pull request Mar 1, 2021
Merged
vladar pushed a commit that referenced this pull request Mar 1, 2021
@ascorbic
fix(create-gatsby): Use legacy peer deps (#29856) (#29862)
8639f7b 
* fix(create-gatsby): Use legacy peer deps

* Update tests

(cherry picked from commit a92b276)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@ajesse11x ajesse11x mentioned this pull request Mar 9, 2021
Open
@kaocher82 kaocher82 mentioned this pull request Mar 9, 2021
Open
This was referenced Mar 9, 2021
Open
Open
This was referenced Mar 9, 2021
Open
Open
This was referenced Mar 9, 2021
Open
Open
Open
@ajesse11x ajesse11x mentioned this pull request Mar 9, 2021
Open
This was referenced Mar 9, 2021
Open
Open
@impactyogi impactyogi mentioned this pull request Mar 26, 2024
Open
This was referenced Mar 26, 2024
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
This was referenced Mar 27, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Mar 28, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Apr 14, 2024
Open
@wizbit wizbit mentioned this pull request Apr 14, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 14, 2024
Open
@monizb monizb mentioned this pull request Apr 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Apr 15, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Apr 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
@monizb monizb mentioned this pull request Apr 29, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 16, 2024
Open
This was referenced May 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: cli Related to the Gatsby CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @LekoArts