Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Fix various small DEV_SSR bugs exposed in development_runtime tests #29748

Merged
merged 5 commits into from
Mar 4, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Feb 24, 2021

Backport of #29720 to v2

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 24, 2021
@KyleAMathews KyleAMathews changed the base branch from master to release/2.32 February 24, 2021 22:17
@KyleAMathews KyleAMathews added topic: ssr and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 24, 2021
@ascorbic
Copy link
Contributor

@KyleAMathews These seem to be real test failures. Could you take a look?

@KyleAMathews
Copy link
Contributor Author

Gah can't reproduce locally. It's a strange error that I'm not sure how my changes would cause:

Your callback function returned a promise that never resolved.

The callback function was:

win => {
    if (!win.___apiHandler) {
      win.___apiHandler = _apiHandler.default.bind(win);
    }

    return _apiHandler.waitForAPI.call(win, api).then(() => subject);
  }

Will add some debugging code I guess to see what api isn't returning.

@KyleAMathews
Copy link
Contributor Author

Ok, turned out I had some left code in assuming DEV_SSR was at 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) type: cherry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants