-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Fix various small DEV_SSR bugs exposed in development_runtime tests #29720
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
009d4f1
the dev server now returns 404s which would otherwise fail the tests
KyleAMathews 4541305
Correctly detect if there's any SSRed HTML as ___gatsby always has th…
KyleAMathews b3a7113
Handle unicode paths like /안녕
KyleAMathews 9b73a27
Properly escape paths with special characters in it
KyleAMathews dee3f58
Enable DEV_SSR for everyone
KyleAMathews 83b63d0
Fix status in test
KyleAMathews aa651e5
Revert to 20% rollout
KyleAMathews 1fbefd5
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews 63e3f3d
revert changes for 100% rollout
KyleAMathews b2799f4
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews 0e95ada
test this
KyleAMathews 9368754
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews 3e36529
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,8 +59,13 @@ export const restartWorker = (htmlComponentRendererPath): void => { | |
|
||
const searchFileForString = (substring, filePath): Promise<boolean> => | ||
new Promise(resolve => { | ||
const escapedSubString = substring.replace(/[.*+?^${}()|[\]\\]/g, `\\$&`) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Handle paths with special characters |
||
|
||
// See if the chunk is in the newComponents array (not the notVisited). | ||
const chunkRegex = RegExp(`exports.ssrComponents.*${substring}.*}`, `gs`) | ||
const chunkRegex = RegExp( | ||
`exports.ssrComponents.*${escapedSubString}.*}`, | ||
`gs` | ||
) | ||
const stream = fs.createReadStream(filePath) | ||
let found = false | ||
stream.on(`data`, function (d) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle paths with unicode characters