feat(gatsby): Enable develop SSR for everyone #29251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
KyleAMathews
removed
the
status: triage needed
|
@KyleAMathews Can you check why the e2e tests are failing? It looks like real failures. |
|
Hmm strange — might be a configuration issue — we've had those tests running with ssr this whole time. Investigating. |
|
Looks like hydration issues 👀 Hrmmm — maybe we weren't running these |
|
|
…or special characters in the path
KyleAMathews
commented
Feb 1, 2021
| @@ -49,8 +49,13 @@ export const restartWorker = (htmlComponentRendererPath): void => { | |||
|
|
|||
| const searchFileForString = (substring, filePath): Promise<boolean> => | |||
| new Promise(resolve => { | |||
| const escapedSubString = substring.replace(/[.*+?^${}()|[\]\\]/g, `\\$&`) | |||
There was a problem hiding this comment.
this was causing failing tests on the development-runtime for paths like -[client-only] as they'd crash the server
| @@ -10,13 +10,13 @@ export const route = ({ app, program, store }): any => | |||
| app.get(`*`, async (req, res, next) => { | |||
| trackFeatureIsUsed(`GATSBY_EXPERIMENTAL_DEV_SSR`) | |||
|
|
|||
| const pathObj = findPageByPath(store.getState(), req.path) | |||
| const pathObj = findPageByPath(store.getState(), decodeURI(req.path)) | |||
There was a problem hiding this comment.
needed for unicode paths like /안녕
| render() { | ||
| if (this.state.hasRendered) { | ||
| return ( | ||
| <ConditionalFastRefreshOverlay> |
There was a problem hiding this comment.
The overlays are client-only so we don't render them initially to avoid React saying there's hydration problems
KyleAMathews
force-pushed
the
dev-ssr-100
branch
from
202675e
to
94d7f6f
Compare
KyleAMathews
commented
Feb 1, 2021
| @@ -2,7 +2,7 @@ const COUNT_ID = `count` | |||
|
|
|||
| describe(`hooks`, () => { | |||
| beforeEach(() => { | |||
| cy.visit(`/hooks`).waitForRouteChange() | |||
| cy.visit(`/hooks`, { failOnStatusCode: false }).waitForRouteChange() | |||
There was a problem hiding this comment.
the dev server now returns 404s
|
Close in favor of #29720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20% rollout went smoothly & time to rock & roll.
PR includes some misc test fixes to fixes issues exposed by rollout.