fix(gatsby-source-filesystem,gatsby-transformer-sharp): Use custom errors #27576
+88
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sslotsky
reviewed
Oct 20, 2020
sslotsky
reviewed
Oct 20, 2020
LekoArts
added
topic: plugins
LekoArts
suggested changes
Oct 22, 2020
wardpeet
reviewed
Oct 22, 2020
LekoArts
changed the title
ax-vasquez
deleted the
armandovasquez/ch17057/useReporterForUnableToCopyError
branch
This was referenced Dec 23, 2020
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In effort to improve the Cloud user experience, we need to make sure "Error copying file from..." errors are appropriately captured/categorized for Builds and Previews.
This PR simply updates the locations where log this error so that it uses
reporter.panicinstead ofconsole.errorTo do
idshould be used for this error? - Any 5-digit number; this is an arbitrary value and contained within the context of the plugin (e.g., there is no risk error code conflicts between modules)idbe different betweengatsby-source-filesystemandgatsby-transformer-sharp(the two places that log this error) - Yes, the module name is included in the ID prefix for both error locations.