Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(unit): fix re-add jest-silent-reporter to unit test CI output #24071

Merged
merged 7 commits into from
May 15, 2020
Merged

chore(unit): fix re-add jest-silent-reporter to unit test CI output #24071

merged 7 commits into from
May 15, 2020
+5 −12

Conversation

Slashgear
Copy link
Contributor

@Slashgear Slashgear commented May 13, 2020 •
edited
Loading

Description

Documentation

Related Issues

@Slashgear Slashgear requested a review from a team as a code owner May 13, 2020 20:41
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 13, 2020
@Slashgear Slashgear mentioned this pull request May 13, 2020
Merged
@pieh pieh added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 13, 2020
@pieh pieh self-assigned this May 13, 2020
@pieh
Copy link
Contributor

pieh commented May 13, 2020

Hah ... bit late on that part from my side ... but our jest config actually had already some setup for jest-junit even before your previous PR - appears like it was added when were trying out azure pipelines for windows testing (before CircleCi had support for it):

gatsby/jest.config.js

Lines 54 to 56 in de49182

reporters: process.env.CI
? [[`jest-silent-reporter`, { useDots: true }]]
: [`default`].concat(useCoverage ? `jest-junit` : []),

So maybe we should re-consider a bit passing CLI commands in circleCI config and adjust jest.config case for CI to also concat jest-junit if useCoverage is truthy - and set GENERATE_JEST_REPORT env var in circleCI config in addition to output dir and name?

@pieh
Copy link
Contributor

pieh commented May 13, 2020

I completely missed that we intentionally switched default reporter to "silent-reporter" (so it only shows failed tests without summary - which is massive with over 3000 tests) and was mentioned in #20457 (review)

@pieh
Copy link
Contributor

pieh commented May 14, 2020

I'll adjust the PR tomorrow to steamline our setup - it is on me for not checking up on jest.config in previous PR :)

pieh
pieh reviewed May 14, 2020
View reviewed changes
jest.config.js
functions: 42,
branches: 43,
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we weren't using them anyway and those were just failing because they tried to analyze fixtures - might be good idea to set them up properly with fixture ignore, but that's not in scope of this PR

@pieh pieh changed the title chore(unit): fix jest report by generating default reporters chore(unit): fix re-add jest-silent-reporter to unit test CI output May 15, 2020
@pieh pieh merged commit 3242894 into gatsbyjs:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Slashgear @pieh