Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update useStaticQuery example code #18681

Conversation

HUFGhani
Copy link
Contributor

@HUFGhani HUFGhani commented Oct 15, 2019

Description

IThe example code snippet found here or look below

Screenshot 2019-10-15 at 09 14 52

this is incorrect and breaks test

Related Issues

Fixes #18679

@HUFGhani HUFGhani requested a review from a team as a code owner October 15, 2019 08:36
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for opening the PR but I left a small suggestion.

docs/docs/testing-components-with-graphql.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 15, 2019
@gatsbybot gatsbybot merged commit 6de032d into gatsbyjs:master Oct 15, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 15, 2019

Holy buckets, @HUFGhani — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing components with GraphQL (useStaticQuery example code is wrong)
3 participants