Use ComponentRenderer for both page/layout components #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview failed. Built with commit c05f6fa https://app.netlify.com/sites/using-glamor/deploys/598df6f36f4c5033411014d0 |
|
Deploy preview ready! Built with commit 45e0e5b |
This happens because dev-only pages (e.g. dev-404-page) can create page data dependencies which in a production build, Gatsby attempts to handle.
KyleAMathews
force-pushed
the
fix-layouts
branch
from
627ba2c
to
70e698b
Compare
|
Deploy preview ready! Built with commit 45e0e5b |
|
Nice work @KyleAMathews 👏 |
This was referenced Dec 23, 2020
This was referenced Feb 9, 2022
This was referenced Jan 2, 2024
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that we never need to render layouts except on page transitions so
the logic for the page & layout rendering are identical so we might as well
use the same component.
This also solves problems where there's a layout change associated with a page change
but the layout renders before the page resources have loaded which causes temporary
broken looking code.
Also should fix #1756
/cc @craig-mulligan & @jbolda