Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: add analytics tags to the plugin search #11693

Merged
merged 3 commits into from
Feb 12, 2019

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Feb 11, 2019

Description

This will make the analytics more relevant, when we can filter for only the Gatsby results

Related Issues

@Haroenv Haroenv requested a review from a team as a code owner February 11, 2019 13:53
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Haroenv 👍 Could you do yarn run format to fix the lint errors?

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks :)

@m-allanson m-allanson merged commit 6e75f5c into gatsbyjs:master Feb 12, 2019
@Haroenv Haroenv deleted the feat/search-analytics branch February 12, 2019 12:16
gurpreet-hanjra pushed a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 14, 2019
* www: add analytics tags to the plugin search

* add import

* Update www/src/components/plugin-searchbar-body.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants