Sync db autosaves #10212
Sync db autosaves #10212
Conversation
There was a problem hiding this comment.
One of @pieh and I will take a look at this in more depth, but first glance, probably a good idea to resolve the mismatched history here, since I think only the last, or last few, commits are relevant!
(It won't really matter because we'll squash anyways, but probably still worth doing!)
pieh
force-pushed
the
sync-db-autosaves
branch
from
83421d4
to
c0c5124
Compare
Moocar
force-pushed
the
sync-db-autosaves
branch
from
c2537b9
to
bbfba35
Compare
|
@DSchau Wow, that was some messed up history. I went for the nuclear option since it's not much code. Should be good to review now. |
Yeah, let's get this in - later on we can do some save queue instead of debouncing or something like that, so we create task that will wait for all "partial" state saves before resolving. But this is good for now - small incremental changes are much nicer to review and reason with |
* master: (1421 commits) feat(gatsby-image): add onStartLoad prop (#6702) fix(docs): add Ecosystem to docs sidebar, consistency with tutorial sidebar (#10350) fix(www): Starters.yaml housekeeping (#10354) docs: add ttag starter (#10352) docs: document branching (#9983) plugin checker initial commit (#7062) docs: new starter features is required (#10353) docs: migrated line highlighting to highlight-line, highlight-start, highlight-end (#10202) Add Birra Napoli to site showcase (#10344) Add BetterDocs to site showcase (#10349) chore(release): Publish Add option to keep metadata in files processed by `gatsby-plugin-sharp` (#10210) fix(gatsby): [loki] sync db autosaves (#10212) Add Ad Hoc Homework to sites.yml (#10346) fix(graphql-skip-limit): declare `graphql` peer dependency (#10305) fix(gatsby-plugin-offline): gracefully degrade if appshell isn't precached (#10329) Service workers note (#10276) fix(docs): link fixes, podcast addition (#10332) feat(docs): Create clearer pathways in docs (#9898) feat(www): Rename community section to creators (#10312) ...
This PR orchestrates the saving of db state for both loki and redux into one place. Previously, loki would use its `autosave` feature and save to disk every 1000ms. Whereas now, it uses the same style as `gatsby/redux` where a debounced save is triggered for each new event. Note that both database save asynchronously (redux's write to disk is async) so this isn't a perfect "Stop the world" synchronized save. However it's better than it was before.
This PR orchestrates the saving of db state for both loki and redux into one place. Previously, loki would use its
autosavefeature and save to disk every 1000ms. Whereas now, it uses the same style asgatsby/reduxwhere a debounced save is triggered for each new event.Note that both database save asynchronously (redux's write to disk is async) so this isn't a perfect "Stop the world" synchronized save. However it's better than it was before.