fix(gatsby-remark-prismjs): prevent additional blank line from appearing #10209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
commented
Nov 29, 2018
| "<span class=\\"gatsby-highlight-code-line\\"> return \\"hello world\\" | ||
| </span>" | ||
| `; | ||
| exports[`highlighting a line range highlight-line highlights line 1`] = `"<span class=\\"gatsby-highlight-code-line\\"> return \\"hello world\\"</span>"`; |
There was a problem hiding this comment.
These diffs are a little messy, but it just removes the hard line breaks from the diffs. This will be handled via HTML start/end tags anyways, so this should be just fine.
DSchau
commented
Nov 29, 2018
| @@ -47,7 +47,7 @@ const stripComment = line => | |||
| ) | |||
|
|
|||
| const wrap = line => | |||
| [`<span class="gatsby-highlight-code-line">`, `${line}\n`, `</span>`].join(``) | |||
| [`<span class="gatsby-highlight-code-line">`, `${line}`, `</span>`].join(``) | |||
There was a problem hiding this comment.
The fix. One character 🆗
pieh
approved these changes
Nov 29, 2018
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…ing (gatsbyjs#10209) * fix(gatsby-remark-prismjs): prevent additional blank line from appearing * chore: don't use template literals; not needed * test: update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug where an extra line character is rendered as the generated HTML contains a structure like
</span>\n</span>. This new line character causes a blank line to be inserted into the resultant highlighted code.I've validated that this doesn't seem to cause any regressions with the kitchen sink.
Changes in this PR
Published version