feat(gatsby-plugin-emotion): upgrade plugin for emotion 10 support #10185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, meant to open this vs. my own repo. Closing 😅 |
|
Aw man, finding this in search results had me excited. 🙂 Is that branch in your fork ready to go, @DSchau? If not, anything I can do to help? |
|
@wKovacs64 feel free to take what I have and run with it! It's mostly done, but it honestly felt a little janky and I wasn't sure if I was doing things in an emotion-recommended way! |
|
This is the most up-to-date changes -> https://github.com/DSchau/gatsby/pull/3/files |
|
Anything in particular you felt was unfinished? I upgraded one of my Gatsby sites to v10 using your branch via gatsby-dev and it seemed fine. Edit: Oh, but I included the |
|
Moved to #10226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.