-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README of Unit Testing section refers to something that doesn't exist #9766
Comments
@mjkrause the best way of going through the Gatsby documentation would be through www.gatsbyjs.org, the links would not work as expected in the Github's README.md For unit testing, please check the following link on gatsbyjs.org: https://www.gatsbyjs.org/docs/unit-testing/ |
No, you’re misunderstanding something here @kakadiadarpan |
Yeah, whoops! Easy fix to remove and re-arrange that paragraph. I did remove the option from Someone want to tackle this? If not, one of us will get to it as soon as we can! |
Fixes issue #9766 <!-- Q. Which branch should I use for my pull request? A. Use `master` branch (probably). Q. Which branch if my change is a bug fix for Gatsby v1? A. In this case, you should use the `v1` branch Q. Which branch if I'm still not sure? A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
I believe this issue can be closed now, since my PR was merged. |
Fixes issue gatsbyjs#9766 <!-- Q. Which branch should I use for my pull request? A. Use `master` branch (probably). Q. Which branch if my change is a bug fix for Gatsby v1? A. In this case, you should use the `v1` branch Q. Which branch if I'm still not sure? A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
Description
Check line Back to the Jest config, you can see the next option is testRegex. This is the pattern telling Jest which files contain tests. The pattern above matches any .js file inside a
__tests__
directory,... in gatsby/docs/docs/unit-testing.md.There is no variable named
testRegex
in the above example ofjest.config.js
. I have seen somewhere below in that file, though. In any case, that reference doesn't seem to be correct.Steps to reproduce
see description
Expected result
Remove that reference, or put
testRegex = ...
into the example.The text was updated successfully, but these errors were encountered: