patch: Updated README with a new rule #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
suggested changes
Oct 9, 2019
Merged
StrikerRUS
reviewed
Oct 10, 2019
muescha
reviewed
Oct 16, 2019
| ``` | ||
|
|
||
| 7. Заголовки должны быть оформлены согласно [документации](https://www.gatsbyjs.org/contributing/gatsby-style-guide/#format-titles-and-headers) | ||
| 8. Следует избегать обращений "мы" и "наш", и использовать ["вы" и "ваш"](https://www.gatsbyjs.org/contributing/gatsby-style-guide/#use-you-as-the-pronoun) |
There was a problem hiding this comment.
Should it be not the formal "вы"/"ваш" but the informal "ты"/"твой"?
There was a problem hiding this comment.
@muescha
By Gatsby Styleguide we should use formal for docs and informal for tutorials, but it's more confusing than helps.
We had small conversation about that here, and decided to go with formal. For Russian speakers is more comfortable to have "вы/ваш".
There was a problem hiding this comment.
Thx for the Info :)
Yes. Better stick to what's better and usual for the reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил пару правил согласно gatsbyjs/gatsby#18284, и правило по стандартному слову для всех заметок
И теперь оказывается, что я был не прав здесь #8 (comment)