-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pulsar recipe #22
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @MRegeard ! This is useful
Since the diff is not very readable, I leave comments here
- Please clear the outputs
- in
0. Dependencies and Imports
, updategammapy-1.0-environment.yml
to1.2
- In the
target_position = SkyCoord()...
do we need the ra and dec to this precision? - In Section 2.1, where you mention checking the
START
andFINISH
entries, maybe you can show how to do that, and that it is valid for this run (using the GTI for the run) - The point with deleting the
JUMP
parameter has to be explained better. Open the file, comment it out, save it, etc. Isn't there any better way? - remove the blank cell at the end
Thanks @AtreyeeS for you comments.
|
Thanks @MRegeard. I've had a look and made some comments. I will also send you some comments via slack which were I was not able to make review comments. |
Co-authored-by: Astro-Kirsty <AstroKirsty@gmail.com>
@Astro-Kirsty, Thanks you very much for your review ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MRegeard ! No further comments. If the comments by @Astro-Kirsty have been addressed, we can merge
We can merge this PR, what do you think @AtreyeeS @registerrier ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MRegeard . See few inline comments.
"\n", | ||
"\n", | ||
"`$ conda env create -n gammapy-pint -f gammapy-1.0-environment.yml`\n", | ||
"`$ conda env create -n gammapy-pint -f gammapy-pint-environment.yml`\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this gammapy-pint-environment.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know. I think that is was the original env file that was presented to the user. But then we also need this env.yml
for the CI. In the end they are the same so I could make gammapy-pint-environment.yml
a simlink to env.
Co-authored-by: Régis Terrier <regis.terrier@m4x.org>
Co-authored-by: Régis Terrier <regis.terrier@m4x.org>
Co-authored-by: Régis Terrier <regis.terrier@m4x.org>
This PR update the pulsar recipe to Gammapy version 1.2 and PINT version 1.0. I also corrected the issue with phase not in the event table print at the end of the recipe.