Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Linter: fix regex for profile version #16480

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[23.0] Linter: fix regex for profile version #16480

merged 2 commits into from
Jul 28, 2023

Conversation

bernt-matthias
Copy link
Contributor

  • did not allow for new style profile versions (that may have only a single digit after the dot)
  • fix: do not allow , in profile version

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Jul 28, 2023
mvdbeek
mvdbeek approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe target 23.0 ?

@bernt-matthias bernt-matthias changed the base branch from dev to release_23.0 July 28, 2023 08:40
@bernt-matthias bernt-matthias changed the title [23.1] Linter: fix regex for profile version [23.0] Linter: fix regex for profile version Jul 28, 2023
@bernt-matthias bernt-matthias force-pushed the fix/profile-regex branch 2 times, most recently from c4c03a1 to 77c0e91 Compare July 28, 2023 15:31
@bernt-matthias
fix regex for profile version
77c0e91 
- did not allow for new style profile versions (that may have only a
  single digit after the dot)
- fix: do not allow `,` in profile version
@bernt-matthias
make pattern even more flexible
4f3b8da 
since in the past releases were quite irregular
@dannon dannon merged commit d9b3ede into galaxyproject:release_23.0 Jul 28, 2023
37 checks passed
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo modified the milestones: 23.2, 23.1 Jul 28, 2023
@bernt-matthias bernt-matthias deleted the fix/profile-regex branch July 28, 2023 22:32
@nsoranzo nsoranzo mentioned this pull request Jul 29, 2023
Merged
4 tasks
bernt-matthias added a commit to bernt-matthias/planemo that referenced this pull request Aug 23, 2023
@bernt-matthias
fix profile version test
e5626c5 
linter has been adapted to new style profile versions
and got a bit more relaxed.

galaxyproject/galaxy#16480
@bernt-matthias bernt-matthias mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/testing area/tool-framework kind/bug
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bernt-matthias @mvdbeek @dannon @nsoranzo