Implements a new conversation UI for an easy overview of all the comments on a case #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbothner
force-pushed
the
conversation
branch
from
4eac4a6
to
540ecec
Compare
cbothner
force-pushed
the
conversation
branch
from
540ecec
to
e2ac13d
Compare
cbothner
force-pushed
the
conversation
branch
5 times, most recently
from
d7f1083
to
215c9df
Compare
cbothner
force-pushed
the
conversation
branch
from
300d5bc
to
0c53fce
Compare
cbothner
force-pushed
the
conversation
branch
from
0c53fce
to
452be0e
Compare
We’re gonna use an Editor because it will make @-ing other users possible down the line
We need to keep focus in CommentThreadsCard when only it’s open then in SelectedCommentThread after it’s been opened. This way only the FocusContainer with the highest priority (tie-broken by last mounted) will try to control focus.
Readers who aren’t enrolled in a certain case and readers who are enrolled in cases that aren’t commentable can’t access conversation view
It’s not connected yet and unattached comments are outside the scope of this PR (large as it is...)
cbothner
force-pushed
the
conversation
branch
from
452be0e
to
531276e
Compare
cbothner
force-pushed
the
conversation
branch
from
defa531
to
4ef1970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork for CaseLog, which will be an instructors-only community on each case, in which most posts are unattached to specific bits of text (see #184)
RE: #102
Closes: #59, #120