Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the redbox-react dependency still needed? [v4] #808

Closed
insin opened this issue Jan 21, 2018 · 4 comments · May be fixed by Omrisnyk/npm-lockfiles#153
Closed

Is the redbox-react dependency still needed? [v4] #808

insin opened this issue Jan 21, 2018 · 4 comments · May be fixed by Omrisnyk/npm-lockfiles#153
Labels
enhancement

Comments

@insin
Copy link
Contributor

insin commented Jan 21, 2018

While playing around with the errorReporter prop in react-hot-loader@next, I noticed it has a dependency on redbox-react which isn't being used - should this be the default errorReporter or is the dependency no longer needed?
@theKashey
Copy link
Collaborator

No longer needed. Good catch.

@gregberge
Copy link
Collaborator

Yes good catch! I had seen it but I forgot, thanks!

@gregberge
Copy link
Collaborator

Let's remove this useless dependency!

gregberge added a commit that referenced this issue Jan 22, 2018
@gregberge
feat: remove useless dependencies
e1b83e5 
Fix #808
@gregberge
Copy link
Collaborator

Fixed in v4.0.0-beta.17.

@gregberge gregberge removed the WIP label Jan 22, 2018
@Omrisnyk Omrisnyk mentioned this issue Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 1 vulnerabilities Omrisnyk/npm-lockfiles
3 participants
@insin @gregberge @theKashey