Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lerna #13

Merged
merged 5 commits into from
May 29, 2017
Merged

Update lerna #13

merged 5 commits into from
May 29, 2017

Conversation

thibautRe
Copy link
Contributor

@thibautRe thibautRe commented May 26, 2017

Overview

This PR aims to use lerna script utils instead of the home-made script that we developed when launching the project.

Instead of using our script, we can now use lerna exec -- babel src -d lib to compile everything.

Some other changes include :

  • Add src/index.js file for fyndiq-styles-fonts, mainly to enable the new compile flow.
  • Remove the homemade identity proxy object, replaced with identity-obj-proxy
  • Use rimraf instead of rm -rf. Less prone to error.

How to test

  • npm run clean to remove all the compiled files
  • npm run build to build the files
  • npm run dev to build and watch the files, and run the storybook.

@Frinsh Frinsh self-requested a review May 29, 2017 08:56
Copy link
Contributor

@Frinsh Frinsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@thibautRe thibautRe merged commit a1747a9 into master May 29, 2017
@thibautRe thibautRe deleted the update-lerna branch May 29, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants