Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 5 blogpost #815

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Week 5 blogpost #815

merged 3 commits into from
Jul 19, 2023

Conversation

JoaoDell
Copy link
Contributor

@JoaoDell JoaoDell commented Jul 4, 2023

Hello, here is my week 5 blogpost:
image

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #815 (db778dc) into master (e595bad) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head db778dc differs from pull request most recent head 4e6a682. Consider uploading reports for the commit 4e6a682 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   84.43%   84.38%   -0.05%     
==========================================
  Files          43       43              
  Lines       10274    10274              
  Branches     1393     1393              
==========================================
- Hits         8675     8670       -5     
- Misses       1239     1243       +4     
- Partials      360      361       +1     

see 1 file with indirect coverage changes

Copy link
Contributor

@tvcastillod tvcastillod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoaoDell, the blogpost was generated successfully, and overall looks great. Please take a look at some minor comments I made.

Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JoaoDell,
Nice Blogpost, LGTM.

@JoaoDell
Copy link
Contributor Author

JoaoDell commented Jul 7, 2023

Thanks for the review @tvcastillod and @ganimtron-10, just pushed the changes you pointed out 👍

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@skoudoro skoudoro merged commit 005a753 into fury-gl:master Jul 19, 2023
18 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants