Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC: Adding Week3 Blogpost #805

Merged
merged 1 commit into from
Jun 23, 2023
Merged

GSoC: Adding Week3 Blogpost #805

merged 1 commit into from
Jun 23, 2023

Conversation

ganimtron-10
Copy link
Contributor

image

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #805 (a1ab8f9) into master (73e0a1a) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   84.41%   84.32%   -0.10%     
==========================================
  Files          43       43              
  Lines       10166    10173       +7     
  Branches     1381     1383       +2     
==========================================
- Hits         8582     8578       -4     
- Misses       1227     1239      +12     
+ Partials      357      356       -1     
Impacted Files Coverage Δ
fury/ui/containers.py 83.98% <100.00%> (+0.09%) ⬆️
fury/ui/elements.py 89.95% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@tvcastillod tvcastillod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10, the blogpost was built successfully. Everything looks good to me.

Copy link
Contributor

@JoaoDell JoaoDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text clarifies well your work, is well written and it built sucessfully here. Everything seems fine!

@ganimtron-10
Copy link
Contributor Author

Thanks @tvcastillod @JoaoDell for reviewing!

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.! thanks for the review and for this PR

@skoudoro skoudoro merged commit b369335 into fury-gl:master Jun 23, 2023
22 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants