Creating an off_focus hook in TextBox2D
#501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganimtron-10
changed the title
on_blur hook in TextBox2Don_blur hook in TextBox2D
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 89.05% 89.14% +0.08%
==========================================
Files 54 54
Lines 11534 11541 +7
Branches 1130 1131 +1
==========================================
+ Hits 10272 10288 +16
+ Misses 962 957 -5
+ Partials 300 296 -4
|
|
Please use |
|
A test is missing too. |
ganimtron-10
changed the title
on_blur hook in TextBox2Doff_focus hook in TextBox2D
|
Hey @skoudoro , |
skoudoro
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Thank you for this PR @ganimtron-10.
Looks good to me. merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To know when the user has completed editing in the
TextBox2D, creating anon_blurhook.Required in #499 .
Also changing the condition sequence in the
handle_characterfunction, because when we press "return" key instead of removing focus from the UI it adds the "\r" character to the message.