Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the project to use cxx as well #43

Closed
wants to merge 1 commit into from

Conversation

ymkim92
Copy link
Contributor

@ymkim92 ymkim92 commented Nov 19, 2023

I got this error when I tried to build the example:

embedded-cli/build$ cmake ..
-- The C compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.10.12", minimum required is "3.0") 
Enable extra flags for GNU
-- Configuring done
CMake Error: Cannot determine link language for target "embedded_cli_linux".
CMake Error: CMake can not determine linker language for target: embedded_cli_linux
-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

The example's source code is cpp file. I think it needs "CXX" as well in the project definition.

I am curious why no one complained about this yet...

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a345459) 81.68% compared to head (d2aea28) 81.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files           2        2           
  Lines         535      535           
  Branches      130      130           
=======================================
  Hits          437      437           
  Misses         64       64           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@funbiscuit
Copy link
Owner

I can't merge your suggestion since lib itself doesn't require C++ while you enable it globally. The reason noone noticed it is probably because c++ was enabled when cmake was run with -DBUILD_TESTS=true. And in CI (where examples are built), tests are also built so there was no error.

I've pushed into master fix to enable C++ also while building examples.

@funbiscuit funbiscuit closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants