Improve quoteJQQuery reliability #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a lookup test that failed when having object with dashes in the name after the scanned object name. - Fix the quoteJQQuery to pass the test. - Unify the quoteJQQuery processing algorithm for all queries, so no special behavior is used for queries with dashes.
- Add a lookup test with negative index. - Fix quoteJQQuery to allow for negative indexes.
Add binary, built with go build to gitignore, so it does not accidentally get commited.
|
@qgrp-m-kondratenko Thank you! I confirmed the bug, and this patch solved it! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a bug when looking up values of objects that have dashes in the name, while being the first key after the scanned object name. In this PR, a few tests were added to replicate that issue as well as a fix for quoteJQQuery function, that was the source of the problem. The logic of quoteJQQuery was simplified to extract all indices and quote them depending on type, numbers with [] and all strings with [""]. Also, the behavior of quoteJQQuery was unified to run the same on queries with and without dashes, which improves the transparency of the query mechanism.