New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lsp types to allow workspace/applyEdit to work #816

Merged

baronfel merged 1 commit into ionide:master from baronfel:lsp-type-fixes

Jul 20, 2021

Contributor

baronfel commented Jul 20, 2021 •

edited

Loading

This adds explicit null value handling to the Version property of the VersionedTextDocumentIdentififer type, so that workspace/applyEdit works.

This endpoint, unlike many other endpoints, requires the property to be present and explicitly null if empty. Rust-analyzer had the same issue.

I also took the opportunity to add some additional clientCapabilities based on the LSP spec.


          fix lsp types to allow workspace/applyEdit to work

7901aff

baronfel mentioned this pull request

Unknown workspace edit change received: ionide/ionide-vscode-fsharp#1385

Closed

baronfel merged commit 0d3c341 into ionide:master

baronfel deleted the lsp-type-fixes branch

July 20, 2021 20:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet