Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown workspace edit change received: #1385

Closed
mastoj opened this issue Jun 17, 2020 · 6 comments
Closed

Unknown workspace edit change received: #1385

mastoj opened this issue Jun 17, 2020 · 6 comments
Labels
bug language services Problems related to language services - FSAC or FCS

Comments

@mastoj
Copy link

mastoj commented Jun 17, 2020

Trying to use "ctrl+." to add the open statement for a namespace but nothing happens. The error message is:

Unknown workspace edit change received

Script file looks like:

#load ".paket/load/netcoreapp3.1/Snowflake.Data.fsx"

open Snowflake.Data
//open Snowflake.Data.Client

let test() =
    let connection = SnowflakeDbConnection()
    ()

test()

Paket.dependencies:

source https://api.nuget.org/v3/index.json

storage: none
framework: netcoreapp3.1, netstandard2.0, netstandard2.1
nuget Snowflake.Data

Let me know if more input is needed to triage this.

@open-collective-bot
Copy link

Hey @mastoj 👋,

Thank you for opening an issue. We will get back to you as
soon as we can. Also, check out our OpenCollective and consider
backing us.

https://opencollective.com/ionide

PS.: We offer backer support for all backers. Don't forget to add backer label when you start backing us 😄

@Krzysztof-Cieslak Krzysztof-Cieslak added bug language services Problems related to language services - FSAC or FCS labels Jun 17, 2020
@Krzysztof-Cieslak
Copy link
Member

Hey, @baronfel have we talked about it recently or memory fails me?

@baronfel
Copy link
Contributor

Is this issue something like:

  • Code is missing an open
  • We provide the codefix for adding the open
  • When using the codefix, the error message described is shown to the user

@Krzysztof-Cieslak I think we've been talking about instances where the codefix doesn't trigger at all (needs upstream fixes) vs instances where the codefix is triggered and fails

@Krzysztof-Cieslak
Copy link
Member

Unknown workspace edit change received

suggest that we send the edit but it's somehow wrong, maybe wrong range due to script file or something?

@seanamos
Copy link

seanamos commented Jun 5, 2021

I occasionally receive this in some files when using symbol renames (F2) as well. There will just be some files where it doesn't work.

@baronfel
Copy link
Contributor

This is probably because workspaceEdits often require the version to be present and we weren't always honoring this. See rust-lang/rust-analyzer#6654 (comment) for details, and ionide/FsAutoComplete#816 for our version of the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug language services Problems related to language services - FSAC or FCS
Projects
None yet
Development

No branches or pull requests

4 participants