Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loohaf to 2.2.1 #516

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

AlinaMoskieva
Copy link
Contributor

@AlinaMoskieva AlinaMoskieva commented Mar 20, 2018

Summary

Update loofah to 2.2.1 to eliminate CVE-2018-8048

Test plan

Run bin/quality and make sure that no vulnerabilities are found

Review notes

While reviewing pull-request (especially when it's your pull-request),
please make sure that:

  • you understand what problem is solved by PR and how is it solved
  • new tests are in place, no redundant tests
  • DB schema changes reflect new migrations
  • newly introduces DB fields have indexes and constraints
  • routes are RESTful, no useless routes
  • there are no missed files (migrations, view templates)
  • required ENV variables added and described in .env.example and added to Heroku
  • associated Heroku review app works correctly with introduced changes

Deploy notes

@timurvafin timurvafin merged commit 48b878b into fs:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants