Custom Target Expressions #2184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validateCustomExpression
Custom Functions prerelease 2 parseCustomExpression
Custom Functions, Finally
added sum_fraction support
Added description for enclosing head units
The legendary return of division operation support!
Minor change in clamp and sum_fraction description
Adding a description for average
typecheck fix
null comma fix disabling focusToSIA a few little things
a few little things
Support for a longer Target paths
pivot: true for custom functions
export custom functions
import custom functions
functional stats did not work
init tab
getTeamData(override)
getTeamData(override)
format
fix test & typecheck & format
|
I don't know why, but since this PR was published I have never encountered the optimizer refusing to work when I used CTE. |
Minimum (un)viable option. Slowly, very slowly...
Better, but still terribly slow...
Fix typecheck
Fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I added support for custom target expressions and a convenient editor.
Since the last PR I have found at least one indisputably correct way to use CTE.
Example: https://discord.com/channels/785153694478893126/1035719815622561892/1244630283052126298
Another example: https://discord.com/channels/785153694478893126/1035720633167921313/1237378233666633850
Testing/validation
The optimizer sometimes refuses to work with some large expressions. Like this:
This can be bypassed by slightly changing the form of the expression without changing the essence.
Also, this case is calculated incorrectly. Although when it is used as part of a larger expression, it is calculated as expected.
I can't fix it. It's an engine issue. I preferred to forget about it until the transition to Pando.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.