Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop-gap for git lfg smudge issue #1374

Closed
wants to merge 1 commit into from
Closed

Stop-gap for git lfg smudge issue #1374

wants to merge 1 commit into from

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Dec 20, 2023

Describe your changes

Currently there is a smudge issue that occurs in our pipeline, likely introduced recently from the datamine.
image

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

Copy link
Contributor

github-actions bot commented Dec 20, 2023

[gi-frontend] [Wed Dec 20 02:52:33 UTC 2023] - Building version

[sr-frontend] [Wed Dec 20 02:52:33 UTC 2023] - Building version

[frontend] [Wed Dec 20 02:52:38 UTC 2023] - Building version

[sr-frontend] [Wed Dec 20 02:53:39 UTC 2023] - Deployed 672181a to https://genshin-optimizer-prs.github.io/pr/1374/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Wed Dec 20 03:03:01 UTC 2023] - Building version 832c9a2

[frontend] [Wed Dec 20 03:03:03 UTC 2023] - Building version 832c9a2

[sr-frontend] [Wed Dec 20 03:03:36 UTC 2023] - Building version 832c9a2

[sr-frontend] [Wed Dec 20 03:04:53 UTC 2023] - Deployed 832c9a2 to https://genshin-optimizer-prs.github.io/pr/1374/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Dec 20 03:06:12 UTC 2023] - Deployed 832c9a2 to https://genshin-optimizer-prs.github.io/pr/1374/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Wed Dec 20 03:06:21 UTC 2023] - Deployed 832c9a2 to https://genshin-optimizer-prs.github.io/pr/1374/gi-frontend (Takes 3-5 minutes after this completes to be available)

[Wed Dec 20 07:04:31 UTC 2023] - Deleted deployment

@nguyentvan7 nguyentvan7 added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 20, 2023
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the PR please, as that controls the commit message

@frzyc frzyc changed the title try something Stop-gap for git lfg smudge issue Dec 20, 2023
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dim is cooking, do not merge

@frzyc frzyc closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants