Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4.3 first half content #1372

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Add 4.3 first half content #1372

merged 3 commits into from
Dec 20, 2023

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Dec 19, 2023

Describe your changes

  • Add Navia
  • Add Verdict and "Ultimate Overlord's Mega Magic Sword"
  • Add Song of Days Past and Nighttime Whispers in the Echoing Woods

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

Copy link
Contributor

github-actions bot commented Dec 19, 2023

[frontend] [Tue Dec 19 06:15:44 UTC 2023] - Building version

[gi-frontend] [Tue Dec 19 06:15:48 UTC 2023] - Building version

[sr-frontend] [Tue Dec 19 06:15:53 UTC 2023] - Building version

[sr-frontend] [Tue Dec 19 06:17:02 UTC 2023] - Deployed 0bef26b to https://genshin-optimizer-prs.github.io/pr/1372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Dec 19 06:18:51 UTC 2023] - Deployed 0bef26b to https://genshin-optimizer-prs.github.io/pr/1372/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Tue Dec 19 06:19:03 UTC 2023] - Deployed 0bef26b to https://genshin-optimizer-prs.github.io/pr/1372/gi-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Dec 19 23:31:13 UTC 2023] - Building version 47e5960

[gi-frontend] [Tue Dec 19 23:31:17 UTC 2023] - Building version 47e5960

[frontend] [Tue Dec 19 23:31:39 UTC 2023] - Building version 47e5960

[sr-frontend] [Tue Dec 19 23:32:22 UTC 2023] - Deployed 47e5960 to https://genshin-optimizer-prs.github.io/pr/1372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Wed Dec 20 02:07:10 UTC 2023] - Building version 47e5960

[sr-frontend] [Wed Dec 20 02:07:15 UTC 2023] - Building version 47e5960

[frontend] [Wed Dec 20 02:07:17 UTC 2023] - Building version 47e5960

[sr-frontend] [Wed Dec 20 02:08:26 UTC 2023] - Deployed 47e5960 to https://genshin-optimizer-prs.github.io/pr/1372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Dec 20 02:17:10 UTC 2023] - Building version 47e5960

[frontend] [Wed Dec 20 02:37:33 UTC 2023] - Building version 669ba1a

[sr-frontend] [Wed Dec 20 02:37:34 UTC 2023] - Building version 669ba1a

[gi-frontend] [Wed Dec 20 02:37:34 UTC 2023] - Building version 669ba1a

[sr-frontend] [Wed Dec 20 02:38:42 UTC 2023] - Deployed 669ba1a to https://genshin-optimizer-prs.github.io/pr/1372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Wed Dec 20 06:38:03 UTC 2023] - Building version 987e4ff

[frontend] [Wed Dec 20 06:38:05 UTC 2023] - Building version 987e4ff

[sr-frontend] [Wed Dec 20 06:38:18 UTC 2023] - Building version 987e4ff

[sr-frontend] [Wed Dec 20 06:39:38 UTC 2023] - Deployed 987e4ff to https://genshin-optimizer-prs.github.io/pr/1372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Dec 20 06:40:13 UTC 2023] - Deployed 987e4ff to https://genshin-optimizer-prs.github.io/pr/1372/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Wed Dec 20 06:40:35 UTC 2023] - Deployed 987e4ff to https://genshin-optimizer-prs.github.io/pr/1372/gi-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Wed Dec 20 06:59:55 UTC 2023] - Building version 987e4ff

[sr-frontend] [Wed Dec 20 06:59:58 UTC 2023] - Building version 987e4ff

[frontend] [Wed Dec 20 07:00:22 UTC 2023] - Building version 987e4ff

[sr-frontend] [Wed Dec 20 07:01:10 UTC 2023] - Deployed 987e4ff to https://genshin-optimizer-prs.github.io/pr/1372/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Wed Dec 20 07:02:28 UTC 2023] - Deployed 987e4ff to https://genshin-optimizer-prs.github.io/pr/1372/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Dec 20 07:02:40 UTC 2023] - Deployed 987e4ff to https://genshin-optimizer-prs.github.io/pr/1372/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Dec 20 17:02:56 UTC 2023] - Deleted deployment

@nguyentvan7 nguyentvan7 added bug Something isn't working and removed bug Something isn't working labels Dec 19, 2023
@frzyc frzyc added bug Something isn't working and removed bug Something isn't working labels Dec 20, 2023
@nguyentvan7 nguyentvan7 merged commit be86d2d into master Dec 20, 2023
10 of 12 checks passed
@nguyentvan7 nguyentvan7 deleted the van/naviaSwift branch December 20, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants