Update roll efficiency calculation

[lantua]

Describe your changes

This updates a max-RV calculation, and fix a minor bug that overestimate max RV in certain scenarios.

Issue or discord link

• https://discord.com/channels/785153694478893126/785176548428087306/1181204144900546613

Testing/validation

Current

Corrected

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

• I have commented my code, in hard-to understand areas.
• I have made corresponding changes to README or wiki.
• For front-end changes, I have updated the corresponding English translations.
• Ran yarn run mini-ci locally to validate format + lint.
• If there were format issues, I ran nx format write to resolve them automatically.

[github-actions]

[frontend] [Mon Dec 4 17:35:02 UTC 2023] - Building version f3d113f

[frontend] [Mon Dec 4 17:37:24 UTC 2023] - Deployed f3d113f to https://genshin-optimizer-prs.github.io/pr/1362/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Mon Dec 4 22:55:38 UTC 2023] - Building version f3d113f

[frontend] [Mon Dec 4 22:56:06 UTC 2023] - Building version f3d113f

[gi-frontend] [Mon Dec 4 22:58:12 UTC 2023] - Deployed f3d113f to https://genshin-optimizer-prs.github.io/pr/1362/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Dec 4 22:58:25 UTC 2023] - Deployed f3d113f to https://genshin-optimizer-prs.github.io/pr/1362/frontend (Takes 3-5 minutes after this completes to be available)

[Fri Dec 8 21:04:11 UTC 2023] - Deleted deployment

[frzyc]

see comment above